Need some advice on my pokemon party for the Elite 4 in sapphire?

I would switch out linoone for metagross and swellow for salamence. Try to evolve machoke if you can, otherwise I would say that your team looks good.